fix(ibis): Resolved MySQL connection error when password is None

[ongdisheng]

Description

This PR fixes a TypeError raised during MySQL connection when the password field is None. Although the password field is optional and defaults to None, passing None directly to ibis.mysql.connect() causes the following error:

TypeError: connect() argument 3 must be str, not None

Canner/WrenAI#1088

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of MySQL connection passwords to prevent issues when no password is provided. The system now consistently passes an empty string instead of None when no password is set.

[coderabbitai]

Walkthrough

The change updates the logic for passing the MySQL password in the connection function, ensuring that an empty string is used instead of None when no password is provided. This adjustment affects how the password argument is handled during MySQL connection setup.

Changes

File(s)	Change Summary
ibis-server/app/model/data_source.py	Modified password handling for MySQL connections to avoid passing None

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant DataSource
    participant MySQL

    Caller->>DataSource: Request MySQL connection
    DataSource->>DataSource: Check if password exists
    alt Password exists
        DataSource->>MySQL: Connect using password.get_secret_value()
    else No password
        DataSource->>MySQL: Connect using empty string as password
    end

Loading

Possibly related PRs

• feat(ibis): Enabled Passwordless Connection for Data Sources BE #1043: Updates password field handling to allow None, complementing this PR's explicit empty string for absent passwords in MySQL connections.

Suggested labels

ibis, python

Suggested reviewers

• goldmedal

Poem

A password, a string, or nothing at all—
Now empty quotes answer the MySQL call.
No more None to cause a fright,
Connections work both day and night.
The code hops on, secure and neat,
With every bug, a tasty treat! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de73780 and eb9cd80.

📒 Files selected for processing (1)

• ibis-server/app/model/data_source.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: ci

🔇 Additional comments (1)

ibis-server/app/model/data_source.py (1)

168-168: LGTM! Proper fix for MySQL None password handling.

The change correctly addresses the MySQL connection error by ensuring an empty string is passed instead of None when no password is provided. This prevents the TypeError: connect() argument 3 must be str, not None mentioned in the PR objectives.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[goldmedal]

Thanks @ongdisheng. It makes sense to me 👍