Skip to content

chore(tool): add manifest extract for query_local_run#1191

Merged
douenergy merged 1 commit intoCanner:mainfrom
goldmedal:chore/extract-mdl-for-script
May 12, 2025
Merged

chore(tool): add manifest extract for query_local_run#1191
douenergy merged 1 commit intoCanner:mainfrom
goldmedal:chore/extract-mdl-for-script

Conversation

@goldmedal
Copy link
Copy Markdown
Contributor

@goldmedal goldmedal commented May 9, 2025

To align the behavior of the real query scenario. I added the manifest extractor to the query_local_run.py script.

Summary by CodeRabbit

  • New Features
    • The script now identifies and uses only the relevant tables from your SQL query, optimizing session initialization.
  • Improvements
    • Adjusted SQL transpilation to use default source dialect.
    • Improved file path handling for function list files.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 9, 2025

Walkthrough

The script now explicitly imports the wren_core module and adds logic to extract and use only the subset of tables referenced in the SQL query from the manifest. It updates the manifest encoding, modifies the session initialization to use the filtered manifest, adjusts file path construction, and changes SQL transpilation to not specify a source dialect.

Changes

File(s) Change Summary
ibis-server/tools/query_local_run.py Imports the full wren_core module. Adds logic to extract and encode only the tables used in the SQL from manifest. Updates session initialization to use filtered manifest. Changes SQL transpilation to unspecified source dialect. Adjusts file path construction for function list.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant QueryLocalRunScript
    participant wren_core.ManifestExtractor
    participant SessionContext

    User->>QueryLocalRunScript: Provide SQL query and manifest
    QueryLocalRunScript->>wren_core.ManifestExtractor: Initialize with manifest
    QueryLocalRunScript->>wren_core.ManifestExtractor: Resolve tables in SQL
    wren_core.ManifestExtractor-->>QueryLocalRunScript: Return used tables
    QueryLocalRunScript->>wren_core.ManifestExtractor: Extract filtered manifest for used tables
    wren_core.ManifestExtractor-->>QueryLocalRunScript: Return filtered manifest
    QueryLocalRunScript->>SessionContext: Initialize with filtered manifest
    QueryLocalRunScript->>SessionContext: Run query
Loading

Suggested labels

ibis, python

Suggested reviewers

  • douenergy

Poem

A hop and a skip, a manifest snip,
Now only the tables you need make the trip.
The SQL is parsed, the context is lean,
With filtered data, the queries are clean.
The bunny approves, with a twitch of its nose—
Efficient and tidy, that's how it goes! 🐇✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added ibis python Pull requests that update Python code labels May 9, 2025
@goldmedal goldmedal requested a review from douenergy May 9, 2025 06:24
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
ibis-server/tools/query_local_run.py (1)

25-25: Redundant import and potential namespace confusion

wren_core is imported in two different styles: from wren_core import SessionContext (line 22) and import wren_core (line 25). While not wrong, keeping a single, consistent import style helps readability and avoids shadowing surprises if wren_core later exposes a top-level SessionContext.

If you only need SessionContext and ManifestExtractor you can shorten the import list and drop the second statement:

-from wren_core import SessionContext
-import wren_core
+from wren_core import SessionContext, ManifestExtractor, to_json_base64

…and then use ManifestExtractor / to_json_base64 directly.
Otherwise, consider aliasing (import wren_core as wc) so it is obvious which names come from the top-level package.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0f888d and 8b18171.

📒 Files selected for processing (1)
  • ibis-server/tools/query_local_run.py (2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
ibis-server/tools/query_local_run.py (2)
wren-core-py/src/extractor.rs (2)
  • extractor (221-223)
  • extract_by (40-42)
wren-core-base/manifest-macro/src/lib.rs (1)
  • manifest (26-56)
🪛 Ruff (0.8.2)
ibis-server/tools/query_local_run.py

64-64: print found

(T201)


69-69: print found

(T201)


70-70: print found

(T201)


73-73: print found

(T201)

⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: validate-pull-request-title
  • GitHub Check: ci
🔇 Additional comments (1)
ibis-server/tools/query_local_run.py (1)

76-76: Verify impact of removing explicit source dialect

Changing read="trino"read=None lets sqlglot auto-detect the dialect.
Auto-detection works most of the time but can mis-classify queries with vendor-specific
functions or identifiers (e.g., IFnull, back-tick quoting). A mis-detected dialect will
lead to silent rewrites and potentially invalid SQL on the target engine.

Please test against a representative set of queries for each supported source to ensure
no regressions, or gate this change behind a switch.

@douenergy
Copy link
Copy Markdown
Contributor

This is very useful. 👍

@douenergy douenergy merged commit dc7cb2a into Canner:main May 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ibis python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants