deps(core): upgrade to datafusion 0.46.1#1124
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThis update modifies dependency versions in the project’s Cargo configuration. In the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
wren-core/Cargo.toml (1)
18-18: Verify DataFusion Fork Stability.
The datafusion dependency now points to a Git repository with the branch "v46.0.1". Ensure that this branch is stable and has been thoroughly tested in your environment. Additionally, for better reproducibility, consider pinning the dependency to a specific commit hash instead of a branch.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
wren-core/Cargo.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: cargo test (win64)
- GitHub Check: cargo test (macos-aarch64)
- GitHub Check: cargo test (macos)
- GitHub Check: test
- GitHub Check: cargo check
- GitHub Check: ci
🔇 Additional comments (1)
wren-core/Cargo.toml (1)
16-16: Ensure Async-Trait Compatibility.
The async-trait dependency has been upgraded from "0.1.80" to "0.1.88". Please verify that this update is backward compatible with our existing asynchronous code usage and that there are no breaking changes introduced in this version.
goldmedal
left a comment
There was a problem hiding this comment.
Thanks @douenergy. Look great!
We use our DataFusion fork to more easily maintain the dependency.
Summary by CodeRabbit