Skip to content

deps(core): upgrade to datafusion 0.46.1#1124

Merged
goldmedal merged 2 commits intoCanner:mainfrom
douenergy:update-datafusion-dependency
Mar 28, 2025
Merged

deps(core): upgrade to datafusion 0.46.1#1124
goldmedal merged 2 commits intoCanner:mainfrom
douenergy:update-datafusion-dependency

Conversation

@douenergy
Copy link
Copy Markdown
Contributor

@douenergy douenergy commented Mar 28, 2025

We use our DataFusion fork to more easily maintain the dependency.

Summary by CodeRabbit

  • Chores
    • Upgraded a core asynchronous utility to a newer version.
    • Adjusted the data processing dependency to follow the latest updates from its development branch.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 28, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • wren-core-py/Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This update modifies dependency versions in the project’s Cargo configuration. In the wren-core/Cargo.toml file, the version of the async-trait dependency is increased from 0.1.80 to 0.1.88. Additionally, the datafusion dependency is changed from a fixed version (46.0.0) to a Git-based dependency referencing a specific branch (v46.0.1) from its repository. These changes adjust how dependencies are sourced and tracked.

Changes

File Change Summary
wren-core/Cargo.toml - Updated async-trait version from 0.1.80 to 0.1.88
- Changed datafusion from version "46.0.0" to a Git dependency on branch "v46.0.1"

Poem

Hopping through code with joy so bright,
I scurry past lines in the soft moonlight.
Upgraded traits and branches at play,
Dependencies refreshed in a merry way.
With every update my heart sings in code delight!


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added core dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Mar 28, 2025
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
wren-core/Cargo.toml (1)

18-18: Verify DataFusion Fork Stability.
The datafusion dependency now points to a Git repository with the branch "v46.0.1". Ensure that this branch is stable and has been thoroughly tested in your environment. Additionally, for better reproducibility, consider pinning the dependency to a specific commit hash instead of a branch.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a03fd60 and 7402d10.

📒 Files selected for processing (1)
  • wren-core/Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: cargo test (win64)
  • GitHub Check: cargo test (macos-aarch64)
  • GitHub Check: cargo test (macos)
  • GitHub Check: test
  • GitHub Check: cargo check
  • GitHub Check: ci
🔇 Additional comments (1)
wren-core/Cargo.toml (1)

16-16: Ensure Async-Trait Compatibility.
The async-trait dependency has been upgraded from "0.1.80" to "0.1.88". Please verify that this update is backward compatible with our existing asynchronous code usage and that there are no breaking changes introduced in this version.

@github-actions github-actions bot added the python Pull requests that update Python code label Mar 28, 2025
Copy link
Copy Markdown
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @douenergy. Look great!

@goldmedal goldmedal merged commit a70c850 into Canner:main Mar 28, 2025
14 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Apr 12, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core dependencies Pull requests that update a dependency file python Pull requests that update Python code rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants