fix(core): handle the unnest table factor for the specific dialect#1104
Merged
douenergy merged 2 commits intoCanner:mainfrom Mar 28, 2025
Merged
fix(core): handle the unnest table factor for the specific dialect#1104douenergy merged 2 commits intoCanner:mainfrom
douenergy merged 2 commits intoCanner:mainfrom
Conversation
Contributor
WalkthroughThe changes introduce a new method Changes
Sequence Diagram(s)sequenceDiagram
participant T as Test Client
participant WD as WrenDialect
participant ID as InnerDialect (BigQueryDialect)
T->>WD: unnest_as_table_factor()
WD->>ID: Delegate the call
ID-->>WD: Return true (BigQuery-specific)
WD-->>T: Return true
sequenceDiagram
participant Test as Async Test
participant SC as SessionContext
participant MB as ManifestBuilder
participant SA as SQL Analyzer
Test->>SC: Create session context
Test->>MB: Build manifest (default & BigQuery)
MB->>SA: Analyze manifest to generate SQL
SA-->>Test: Return SQL query with proper unnest transformation
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (6)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
goldmedal
commented
Mar 25, 2025
| let analyzed_mdl = Arc::new(AnalyzedWrenMDL::analyze(manifest)?); | ||
| let sql = "select * from unnest([1, 2, 3])"; | ||
| let actual = transform_sql_with_ctx(&ctx, analyzed_mdl, &[], sql).await?; | ||
| assert_eq!(actual, "SELECT \"UNNEST(make_array(Int64(1),Int64(2),Int64(3)))\" FROM UNNEST([1, 2, 3])"); |
Contributor
Author
There was a problem hiding this comment.
It's not a valid SQL for BigQuery actually. See apache/datafusion#15233
douenergy
approved these changes
Mar 28, 2025
Contributor
douenergy
left a comment
douenergy
left a comment
There was a problem hiding this comment.
LTGM , Thanks @goldmedal
This was referenced Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
unnest_as_table_factoris required for the specific dialect only (e.g. BigQuery). We should enable it for BigQuery only.Summary by CodeRabbit
New Features
Tests