chore(wren-ai-service): refactor #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cyyeh
commented
Nov 20, 2024
•
cyyeh
commented
- simplify pipeline dry run
- use formal version of AsyncDriver instead of experimental version
- unify configuration for apis
cyyeh
added
module/ai-service
paopa
approved these changes
Nov 21, 2024
Comment on lines
+23
to
+24
| from src.web.v1.services import Configuration | ||
| from src.web.v1.services.ask import AskHistory |
There was a problem hiding this comment.
nitpick: we could consider moving them into pipeline layer in the future. i think it can reduce the bi-dependency between pipeline and service layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.