Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wren-ui): Asking experience enhancement #899

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Conversation

andreashimin
Copy link
Contributor

Description

This PR aims to enhance the experience of create asking to create thread within home page & home/[id] page.

It has modified the following issues:

  • Fill the loading timeframe when CreateAsking to Searching state & CreateThread to Generating state
    (Currently state only appear while polling AskingTask, this changes make the state also appear while CreateAsking & CreateThread)
  • Show thread title & question first while polling thread response
  • Show fade-in animation after the answer polling done & give last answer a min-height to reduce the flicker caused by scroll top changed
  • Remove global loading in home & home/[id] pages

Recording

  • Before
Screen.Recording.2024-11-12.at.6.04.56.PM.mov
  • After
Screen.Recording.2024-11-12.at.5.57.08.PM.mov

Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreashimin andreashimin merged commit 572cbd0 into main Nov 13, 2024
7 checks passed
@andreashimin andreashimin deleted the chore/enhancement branch November 13, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/ui UI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants