Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wren-ui): see an error when editing a relationship in the defined relationships step of onboarding #872

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

fredalai
Copy link
Contributor

@fredalai fredalai commented Nov 6, 2024

Describe the bug

The user can see the This relationship already exists. error when editing a relationship in the Define relationships step of onboarding.

To Reproduce

Steps to reproduce the behavior:

  1. Start onboarding flow
  2. Use a database with primary and foreign keys (E.g., Pagila database)
  3. Complete the connection to the database, select all tables, and successfully enter the Define relationships step page.
  4. After seeing the recommended relationships appear on the table, edit a relationship
  5. See This relationship already exists. error
截圖 2024-10-31 上午12 03 31

Expected behavior

Will not see the error message when editing a relationship in the Define relationships step of onboarding.

UI Screenshots

Will not see the error message when editing a relationship in the Define relationships step of onboarding.

截圖 2024-11-06 下午1 23 19

Rule validator works well

截圖 2024-11-06 下午1 22 44

Update relationship

截圖 2024-11-06 下午1 23 45

截圖 2024-11-06 下午1 23 41
截圖 2024-11-06 下午2 39 56

@fredalai fredalai added the module/ui UI related label Nov 7, 2024
Copy link
Contributor

@andreashimin andreashimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fredalai fredalai merged commit a70dac0 into main Nov 15, 2024
7 checks passed
@fredalai fredalai deleted the fix/define-relationship branch November 15, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/ui UI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants