Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wren-ui): Support record type in BigQuery #701

Merged
merged 13 commits into from
Oct 8, 2024
Merged

feat(wren-ui): Support record type in BigQuery #701

merged 13 commits into from
Oct 8, 2024

Conversation

andreashimin
Copy link
Contributor

Description

Support record type in BigQuery

UI Screenshots

image image

@andreashimin andreashimin added ci/ui and removed ci/ui labels Oct 3, 2024
@andreashimin andreashimin force-pushed the feature/support-record-type-column branch from 31fd13c to 7c90887 Compare October 3, 2024 06:14
fredalai
fredalai approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for frontend part.

onlyjackfrost
onlyjackfrost reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@onlyjackfrost onlyjackfrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the database schema and the usage, others LGTM

wren-ui/migrations/20240928165009_add_model_nested_column.js Outdated Show resolved Hide resolved
wren-ui/migrations/20240928165009_add_model_nested_column.js Outdated Show resolved Hide resolved
@andreashimin
Copy link
Contributor Author

Hi @onlyjackfrost, I have renamed the migration file & replace the filter condition to columnId in de52d8f.
Please kindly help review again when you have time, thanks :D

onlyjackfrost
onlyjackfrost approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@onlyjackfrost onlyjackfrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreashimin andreashimin merged commit cf86f13 into main Oct 8, 2024
7 checks passed
@andreashimin andreashimin deleted the feature/support-record-type-column branch October 8, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredalai fredalai fredalai approved these changes

@onlyjackfrost onlyjackfrost onlyjackfrost approved these changes

@wwwy3y3 wwwy3y3 Awaiting requested review from wwwy3y3

Assignees
No one assigned
Labels
ci/ui module/ui UI related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreashimin @onlyjackfrost @fredalai