chore(wren-ai-service): retrieval improvement #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyeh
added
module/ai-service
cyyeh
force-pushed
the
chore/ai-service/retrieval-improvement
branch
8 times, most recently
from
08297f9 to
1a96ec5
Compare
cyyeh
force-pushed
the
chore/ai-service/retrieval-improvement
branch
2 times, most recently
from
99417d4 to
71e5765
Compare
cyyeh
force-pushed
the
chore/ai-service/retrieval-improvement
branch
from
71e5765 to
1b628ba
Compare
paopa
approved these changes
Aug 30, 2024
Comment on lines
+41
to
+56
| should_force_deploy=bool(os.getenv("SHOULD_FORCE_DEPLOY", "")), | ||
| column_indexing_batch_size=( | ||
| int(os.getenv("COLUMN_INDEXING_BATCH_SIZE")) | ||
| if os.getenv("COLUMN_INDEXING_BATCH_SIZE") | ||
| else 50 | ||
| ), | ||
| table_retrieval_size=( | ||
| int(os.getenv("TABLE_RETRIEVAL_SIZE")) | ||
| if os.getenv("TABLE_RETRIEVAL_SIZE") | ||
| else 10 | ||
| ), | ||
| table_column_retrieval_size=( | ||
| int(os.getenv("TABLE_COLUMN_RETRIEVAL_SIZE")) | ||
| if os.getenv("TABLE_COLUMN_RETRIEVAL_SIZE") | ||
| else 1000 | ||
| ), |
There was a problem hiding this comment.
just mention first, and I don't think it need to be done in this PR. we can consider to use a config class to initial all env and it will make the code more concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indexing pipeline:
COLUMN_INDEXING_BATCH_SIZEwhich users can decide how many columns to index in one document at one timeretrieval pipeline:
TABLE_RETRIEVAL_SIZE) tables based on table name and table descriptions (table_descriptions collection)TABLE_COLUMN_RETRIEVAL_SIZE) tables and columns based on previous results (db_schma)we also expose two env vars for table and column selection:
TABLE_RETRIEVAL_SIZEandTABLE_COLUMN_RETRIEVAL_SIZE