Skip to content

fix(deps): upgrade grpc-go to v1.79.3 (critical CVE)#2173

Merged
onlyjackfrost merged 3 commits intomainfrom
fix/dependabot-236-grpc-authz-bypass
Mar 26, 2026
Merged

fix(deps): upgrade grpc-go to v1.79.3 (critical CVE)#2173
onlyjackfrost merged 3 commits intomainfrom
fix/dependabot-236-grpc-authz-bypass

Conversation

@onlyjackfrost
Copy link
Copy Markdown
Contributor

@onlyjackfrost onlyjackfrost commented Mar 26, 2026

Summary

  • Upgrades google.golang.org/grpc from v1.74.2 to v1.79.3 in wren-launcher/go.mod
  • Fixes Dependabot alert #236: gRPC-Go authorization bypass via missing leading slash in :path header (critical severity)

Test plan

  • Verify wren-launcher builds successfully
  • Run existing tests to ensure no regressions from transitive dependency upgrades

Summary by CodeRabbit

  • Chores
    • Updated underlying Go dependencies for observability, networking, and security to newer stable releases to improve reliability and compatibility.
  • Style
    • Minor formatting adjustment to a public constant (cosmetic only; no behavioral change).

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 32ead86b-c9af-4d51-b684-ec152c81a8c3

📥 Commits

Reviewing files that changed from the base of the PR and between cef6dec and 0534c8e.

⛔ Files ignored due to path filters (1)
  • wren-launcher/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • wren-launcher/go.mod
  • wren-launcher/utils/docker.go

Walkthrough

Updated indirect Go module versions in wren-launcher/go.mod (OpenTelemetry, gRPC/protobuf, golang.org/x/*, backoff, grpc-gateway). Minor whitespace formatting change to WREN_PRODUCT_VERSION in wren-launcher/utils/docker.go. No exported APIs or functional behavior changed.

Changes

Cohort / File(s) Summary
Go Module Dependency Updates
wren-launcher/go.mod
Bumped multiple indirect dependencies: OpenTelemetry packages, github.com/cenkalti/backoff → v5, github.com/grpc-ecosystem/grpc-gateway bumped, google.golang.org/grpc/protobuf/genproto updated, and several golang.org/x/* modules advanced. No source/API changes.
Formatting tweak
wren-launcher/utils/docker.go
Whitespace/alignment adjustment of exported constant WREN_PRODUCT_VERSION (value unchanged).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • wwwy3y3

Poem

🐰 I hopped through modules, tidy and bright,
Bumped OTEL, gRPC, and deps through the night.
A nibble of whitespace, a version well spun—
The launcher stands ready, the upgrades all done! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: upgrading grpc-go to address a critical CVE vulnerability.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dependabot-236-grpc-authz-bypass

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@wren-launcher/go.mod`:
- Around line 146-150: The go.mod lists mismatched OpenTelemetry module
versions: the exporters otlpmetricgrpc, otlpmetrichttp, otlptrace, and
otlptracegrpc
(go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc,
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp,
go.opentelemetry.io/otel/exporters/otlp/otlptrace,
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc) are pinned at
v1.35.0 while core SDK modules (go.opentelemetry.io/otel/sdk/metric and core
otel) are v1.39.0; update those exporter module versions to v1.39.0 (and any
other otlp exporter entries around lines ~200) so all OpenTelemetry modules use
the coordinated v1.39.0 series to resolve the go mod version conflict.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c40e8c08-cf3f-48ad-bee6-9ccd7a4d7e0c

📥 Commits

Reviewing files that changed from the base of the PR and between d93835b and 77b30ee.

⛔ Files ignored due to path filters (1)
  • wren-launcher/go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • wren-launcher/go.mod

Copy link
Copy Markdown
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fixes critical security vulnerability (Dependabot alert #236):
gRPC-Go authorization bypass via missing leading slash in :path header.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@onlyjackfrost onlyjackfrost force-pushed the fix/dependabot-236-grpc-authz-bypass branch from 77b30ee to 5008e6b Compare March 26, 2026 06:09
onlyjackfrost and others added 2 commits March 26, 2026 14:20
Addresses CodeRabbit review: OTLP exporters were at v1.35.0 while
otel core was bumped to v1.39.0. OpenTelemetry Go expects coordinated
versioning across all modules.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@onlyjackfrost
Copy link
Copy Markdown
Contributor Author

@CodeRabbit review again

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

@onlyjackfrost Sure, I'll review the PR again right away!

✅ Actions performed

Full review triggered.

@onlyjackfrost onlyjackfrost merged commit d80cb94 into main Mar 26, 2026
12 of 13 checks passed
@onlyjackfrost onlyjackfrost deleted the fix/dependabot-236-grpc-authz-bypass branch March 26, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants