Skip to content

feat(wren-ui): Update View SQL tab content and add adjust SQL UI#1484

Merged
fredalai merged 8 commits intoepic/adjust-answerfrom
feature/adjust-sql
Apr 1, 2025
Merged

feat(wren-ui): Update View SQL tab content and add adjust SQL UI#1484
fredalai merged 8 commits intoepic/adjust-answerfrom
feature/adjust-sql

Conversation

@fredalai
Copy link
Copy Markdown
Contributor

Description

This PR introduces the new Adjust SQL feature and removes the SQL breakdown function.
Here, only update the UI components first, and APIs integration will be completed through other PRs.

Task

  • Update View SQL tab content - remove SQL breakdown UI
  • Show thread response SQL statement and adjust SQL UI
  • Show View restuls button
  • Add Adjusted answer block

UI

View SQL tab content

截圖 2025-03-28 下午2 12 11

For allow show original SQL

截圖 2025-03-28 下午2 56 46

Adjust SQL Modal

截圖 2025-03-28 下午2 12 20

Adjusted answer block

截圖 2025-03-28 下午2 38 06

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fredalai fredalai force-pushed the feature/adjust-sql branch from 26f49fd to 1d63986 Compare March 28, 2025 07:05
@fredalai fredalai requested a review from andreashimin March 28, 2025 07:10
@fredalai fredalai marked this pull request as ready for review March 28, 2025 07:10
@fredalai fredalai requested a review from Copilot March 28, 2025 07:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the SQL UI in Wren UI by replacing the legacy SQL breakdown functionality with a new Adjust SQL feature. Key changes include:

  • Removing the old SQL breakdown UI and associated hooks and components.
  • Introducing a new Adjust SQL modal with preview and submission functionalities.
  • Updating the store and answer components to support the Adjust SQL feature.

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
wren-ui/src/pages/home/[id].tsx Added AdjustSQLModal import, initialized modal actions, and integrated modal opening in thread handlers.
wren-ui/src/hooks/useAnswerStepContent.tsx Removed the legacy SQL breakdown hook and related UI actions.
wren-ui/src/components/pages/home/promptThread/store.tsx Added new store function for opening the Adjust SQL modal.
wren-ui/src/components/pages/home/promptThread/ViewSQLTabContent.tsx Created a new component to view SQL and trigger Adjust SQL modal.
wren-ui/src/components/pages/home/promptThread/TextBasedAnswer.tsx Integrated Adjust SQL modal invocation on adjustment action.
wren-ui/src/components/pages/home/promptThread/AnswerResult.tsx Replaced the old BreakdownAnswer with the new ViewSQLTabContent and added a placeholder for adjustment information.
wren-ui/src/components/modals/AdjustSQLModal.tsx Introduced a new modal component for adjusting SQL with preview and submission behavior.
wren-ui/src/components/editor/CodeBlock.tsx Updated the copyable implementation with custom icon buttons and adjusted spacing.
Files not reviewed (1)
  • wren-ui/src/styles/components/button.less: Language not supported
Comments suppressed due to low confidence (1)

wren-ui/src/components/editor/CodeBlock.tsx:46

  • [nitpick] Verify that the increased right margin for the copyable text aligns with the overall UI design standards, as this seems to be a deliberate design change.
right: 20px;

@fredalai fredalai requested a review from andreashimin April 1, 2025 03:13
@fredalai fredalai force-pushed the feature/adjust-sql branch 2 times, most recently from b55bdf7 to dad6ed3 Compare April 1, 2025 07:38
Copy link
Copy Markdown
Contributor

@andreashimin andreashimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fredalai fredalai force-pushed the feature/adjust-sql branch from dad6ed3 to 209eb12 Compare April 1, 2025 08:24
@fredalai fredalai merged commit a642e49 into epic/adjust-answer Apr 1, 2025
5 checks passed
@fredalai fredalai deleted the feature/adjust-sql branch April 1, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants