-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: Implement sql-pair API #1372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
faf147c
feat(wren-ui): introduce sql-pair related API
onlyjackfrost f00025c
implement generateQuestion mutation and fix defect
onlyjackfrost 44825b5
validate sql before saving sql pair
onlyjackfrost 5e48c55
add condition to do sql validation
onlyjackfrost f8f78f0
add INVALID_SQL_ERROR error massage
onlyjackfrost 15e2990
refactor sqlPairResolver.ts
onlyjackfrost 42419ea
refactor places where mentioned in comments
onlyjackfrost 72d0f68
fix lint
onlyjackfrost File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
wren-ui/migrations/20250102074256_create_sql_pair_table.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /** | ||
| * @param { import("knex").Knex } knex | ||
| * @returns { Promise<void> } | ||
| */ | ||
| exports.up = function (knex) { | ||
| return knex.schema.createTable('sql_pair', (table) => { | ||
| table.increments('id').primary(); | ||
| table | ||
| .integer('project_id') | ||
| .notNullable() | ||
| .comment('Reference to project.id'); | ||
| table.text('sql').notNullable(); | ||
| table.string('question', 1000).notNullable(); | ||
| table.timestamps(true, true); | ||
|
|
||
| table.foreign('project_id').references('id').inTable('project'); | ||
| }); | ||
| }; | ||
|
|
||
| /** | ||
| * @param { import("knex").Knex } knex | ||
| * @returns { Promise<void> } | ||
| */ | ||
| exports.down = function (knex) { | ||
| return knex.schema.dropTable('sql_pair'); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
wren-ui/src/apollo/server/repositories/sqlPairRepository.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { Knex } from 'knex'; | ||
| import { BaseRepository, IBasicRepository } from './baseRepository'; | ||
|
|
||
| export interface SqlPair { | ||
| id: number; // ID | ||
| projectId: number; // Reference to project.id | ||
| sql: string; // SQL query | ||
| question: string; // Natural language question | ||
| } | ||
|
|
||
| export interface ISqlPairRepository extends IBasicRepository<SqlPair> {} | ||
|
|
||
| export class SqlPairRepository | ||
| extends BaseRepository<SqlPair> | ||
| implements ISqlPairRepository | ||
| { | ||
| constructor(knexPg: Knex) { | ||
| super({ knexPg, tableName: 'sql_pair' }); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.