chore(wren-ui): update release image flow and revert package.json version#1350
chore(wren-ui): update release image flow and revert package.json version#1350onlyjackfrost merged 1 commit intomainfrom
Conversation
WalkthroughThis pull request restructures the GitHub Actions workflow by moving the Changes
Sequence Diagram(s)sequenceDiagram
participant B as Build-Image
participant M as Merge
participant T as Tag-UI-Version
B->>M: Build-image completes
M->>T: Trigger tag-ui-version after merge
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/ui-release-image-stable.yaml (2)
94-94: Inclusion of Tag Variables in Manifest Creation
In the step that creates the manifest list (line 94), the inclusion of the$TAGSvariable is now clearly delineated. Make sure that$TAGSis always correctly populated by the previous metadata extraction; any failure in its generation might lead to issues during manifest creation.
95-150: New "tag-ui-version" Job Structural Review
This new job implements several key actions for updating the UI version and tagging the release:
- Token Generation & Checkout:
The use ofactions/create-github-app-token@v1(lines 99–104) followed by the checkout with a full fetch (fetch-depth: 0) ensures the workflow has the necessary permissions and history to operate correctly.- Git Configuration:
Configuring Git with the bot’s credentials (lines 111–112) is an appropriate approach for automated commits.- Change Log Generation:
The change log is generated by calculating the diff from the previous version (lines 116–140). While the segmentation of commits (features versus fixes/chores) is helpful, consider verifying that thepackage.jsonfile (located per the defaultworking-directory: wren-ui) is always correctly targeted so that thejqextraction at line 117 works reliably.- Version Update & Tagging:
The in-place update viased(line 144) and subsequent commit and tagging (lines 145–149) are correctly implemented. One potential improvement is to handle the possibility of no changes detected—if the version is already updated, the commit may fail. Implementing a conditional check could make this step more robust.Overall, this job aligns with the revised release flow by running after the merge step, ensuring the versioning and tagging are performed as a final step post-merge.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ui-release-image-stable.yaml(2 hunks)wren-ui/package.json(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- wren-ui/package.json
🔇 Additional comments (1)
.github/workflows/ui-release-image-stable.yaml (1)
65-65: Dependency Ordering in the Merge Job
Themergejob’s dependency is now explicitly set to[build-image], which aligns with the new intended flow where the image is built first and then merged. Please verify that no downstream steps rely on other jobs that were previously chained.
2 participants
Description
revert package.json version cause image build failed
https://github.com/Canner/WrenAI/actions/runs/13626690757
adjust image build workflow
Summary by CodeRabbit