Release v4.0.0 #55
Merged
Release v4.0.0 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Learn Page (placeholder) - Add Docs Page (placeholder) - Add Menu to Nav - Improve on-load homepage display
- Modify Learn - Modify Docs - Add Get Started - Cleanup references ahead of more changes
- Need to convert Components to JSX and remove folders/scss
- Add VSCode workspace setting file - Update package.json Close #44
- Add Learn Page (placeholder) - Add Docs Page (placeholder) - Add Menu to Nav - Improve on-load homepage display
- Modify Learn - Modify Docs - Add Get Started - Cleanup references ahead of more changes
- Need to convert Components to JSX and remove folders/scss
- All pages load, shows concept of new Navbar and other components
- Re-add news section - Check if feed is null before displaying something - Add feed fetch in SSR in index.js
# Conflicts: # components/docs/docs.js # components/home/home.js # components/home/news/index.js # pages/docs.js # pages/index.js # styles/docs.scss
into develop * 'develop' of https://github.com/CameraKit/camerakit-website: Add AlphaApps to Company Slider Remove unused import in social-meta Add Pega to Companies Slider
austinkettner
requested review from
Namaskar-1F64F,
emersoncloud,
adrianmteo and
dwillmc
and removed request for
adrianmteo,
Namaskar-1F64F and
emersoncloud
|
@dwillmc @timone @adrianmateoaea24 @emersoncloud please review and then I will merge for deployment into production. |
adrianmteo
requested changes
Nov 28, 2018
|
@adrianmateoaea24 improved the mobile display which your comment made me take a look at, but gonna leave that edge case untouched. Please re-review and if nothing else, give it the ole approval! |
…tact The <Link> element for accesing Docs results in a page that is blank. I added the check to see if the page is trying to be rendered on the client and refresh the page if it is.
emersoncloud
approved these changes
Nov 29, 2018
adrianmteo
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #58
Close #57