Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1 Safari video+audio recording #21

Merged
merged 3 commits into from
Mar 26, 2019
Merged

V1 Safari video+audio recording #21

merged 3 commits into from
Mar 26, 2019

Conversation

exPHAT
Copy link
Member

@exPHAT exPHAT commented Mar 24, 2019 •
edited
Loading

Notable changes:

  • Revert separate audio file commits
  • Replace webm-wasm with webm-media-recorder to add audio recording to videos (currently may go out of sync)
  • Replace yarn.lock in favor of package-lock.json
  • Changes to readme to better outline file hosting
  • Update example to host new module files
  • Add basic typings for webm-media-recorder

exPHAT added 2 commits March 16, 2019 16:05
@exPHAT
Revert "Merge pull request #16 from CameraKit/feature/hack_audio_supp…
916e58c 
…ort"

This reverts commit ed82a6b, reversing
changes made to e068fec.
@exPHAT
Add webm-media-recorder
00c22a7 
- Add webm-media-recorder to dependencies
- Remove yarn.lock in favor of package-lock.json
- Update FallbackMediaRecorder to use new dep
- Remove unneeded code from NativeMediaRecorder
- Add mimeType option to FallbackMediaRecorderConfig
- Declare typings for webm-media-recorder
@exPHAT exPHAT added this to the 0.3.0 milestone Mar 24, 2019
@exPHAT exPHAT self-assigned this Mar 24, 2019
@exPHAT
Update readme and prepare production build
5a4fde7 
- Better outlines Safari support in the readme
- Updates the webpack config to use the webm-media-recorder files over the previous webm-wasm
@exPHAT exPHAT requested a review from austinkettner March 26, 2019 02:35
@austinkettner austinkettner merged commit 0b1faaf into develop Mar 26, 2019
@austinkettner austinkettner deleted the feature/safari_audio_encoding branch March 26, 2019 13:04
@austinkettner austinkettner mentioned this pull request Mar 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinkettner austinkettner austinkettner approved these changes

Assignees

@exPHAT exPHAT

Labels
Status: Review Needed Type: Enhancement
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@exPHAT @austinkettner