Fix NullPointerException when getting camera preview resolution #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logcat:
java.lang.NullPointerException: Attempt to invoke virtual method ‘int com.wonderkiln.camerakit.Size.getHeight()’ on a null object reference
at com.wonderkiln.camerakit.Camera1.getPreviewResolution(Camera1.java:599)
at com.wonderkiln.camerakit.CameraView.getPreviewSize(CameraView.java:518)
at com.wonderkiln.camerakit.CameraView.onMeasure(CameraView.java:197)
lucasmacielc
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this crash on v0.13.6.
This PR fixed the exception when the device is trying the perform view onMeasure() but the camera is not opened yet.
So the getCameraPreviewResolution() method will return
null(which is fine because the CameraView will adjust later), however, if we also want to invert PreviewSizes, the NullException comes up.The solution is simply adding the null check.
Logcat:
java.lang.NullPointerException: Attempt to invoke virtual method ‘int com.wonderkiln.camerakit.Size.getHeight()’ on a null object reference
at com.wonderkiln.camerakit.Camera1.getPreviewResolution(Camera1.java:599)
at com.wonderkiln.camerakit.CameraView.getPreviewSize(CameraView.java:518)
at com.wonderkiln.camerakit.CameraView.onMeasure(CameraView.java:197)