Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 Refactoring #13

Merged
merged 5 commits into from
Jun 19, 2021
Merged

V2 Refactoring #13

merged 5 commits into from
Jun 19, 2021

Conversation

Chocksy
Copy link
Contributor

@Chocksy Chocksy commented Apr 29, 2021

This is quite big of a PR. But i thought i would share it.

Things i did

  • i added rubocop gems for development
  • i changed the endpoints capabilities to be much more limiting as the V2 API is quite smaller.
  • i updated the specs to reflect all of that

Notes

  • the projects endpoints are not fully supported because Dribbble does not have a GET project/:id endpoint.

Calyhre
Calyhre approved these changes Jun 7, 2021
View reviewed changes
Copy link
Owner

@Calyhre Calyhre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very impressive PR, thank you very much for it! I missed the moment you posted it and how Dribbble documentation was at that moment, did they enabled the missing routes on projects since then? Otherwise that looks to me 👏

lib/dribbble/project.rb Outdated Show resolved Hide resolved
@Calyhre
Copy link
Owner

Calyhre commented Jun 7, 2021

Seems like rubocop-rake depends on ruby >= 2.4 and that would be why the CI is failing. I think we can safely drop support for rubies < 2.4, what do you think?

@Chocksy
Copy link
Contributor Author

Chocksy commented Jun 8, 2021

Seems like rubocop-rake depends on ruby >= 2.4 and that would be why the CI is failing. I think we can safely drop support for rubies < 2.4, what do you think?

Yep i 100% agree. On the project we are using this we have ruby 2.7.3 so it won't affect us by any means.

@Chocksy
Copy link
Contributor Author

Chocksy commented Jun 11, 2021

@Calyhre we should be good now. I added those endpoints back and removed the ruby < 2.4 versions.

Calyhre
Calyhre approved these changes Jun 19, 2021
View reviewed changes
Copy link
Owner

@Calyhre Calyhre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you again for all the good stuff 👏

@Calyhre Calyhre merged commit 1b1ad9a into Calyhre:master Jun 19, 2021
@Calyhre
Copy link
Owner

Calyhre commented Jun 19, 2021

Published -> https://rubygems.org/gems/dribbble/versions/2.0.0

@Calyhre Calyhre mentioned this pull request Jun 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calyhre Calyhre Calyhre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chocksy @Calyhre