-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve return types for Table methods #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity|newEmptyEntity|patchEntity|findOrCreate|saveOrFail
…the first argument: Table::saveOrFail, Table::patchEntity
…the first argument: Table::save, Table::saveManyOrFail and Table::deleteManyOrFail
…s the first argument: Table::saveMany and Table::deleteMany
…s the first argument: Table::patchEntities
…M\Association\BelongsTo<\App\Model\Table\UsersTable> $Users`
…t covered by backward compatibility promise. The class might change in a minor PHPStan version.
steinkel
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved return types, this will cover models without custom phpdoc
@method
Provide correct return type for
Cake\ORM\Table::get
based on your table class nameProvide correct return type for
Cake\ORM\Table::newEntity
based on your table class nameProvide correct return type for
Cake\ORM\Table::newEntities
based on your table class nameProvide correct return type for
Cake\ORM\Table::newEmptyEntity
based on your table class nameProvide correct return type for
Cake\ORM\Table::findOrCreate
based on your table class nameProvide correct return type for
Cake\ORM\Table::patchEntity
based on the first argument passedProvide correct return type for
Cake\ORM\Table::patchEntities
based on the first argument passedProvide correct return type for
Cake\ORM\Table::save
based on the first argument passedProvide correct return type for
Cake\ORM\Table::saveOrFail
based on the first argument passedProvide correct return type for
Cake\ORM\Table::saveMany
based on the first argument passedProvide correct return type for
Cake\ORM\Table::saveManyOrFail
based on the first argument passedProvide correct return type for
Cake\ORM\Table::deleteMany
based on the first argument passedProvide correct return type for
Cake\ORM\Table::deleteManyOrFail
based on the first argument passedFixed how extension detect Table::findBy* to correct set expected parameters and return type.
Improved integration tests with rules