Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client id in cookie #590

Merged
merged 10 commits into from
Jan 17, 2019
Merged

Client id in cookie #590

merged 10 commits into from
Jan 17, 2019

Conversation

tpazderka
Copy link
Collaborator

@tpazderka tpazderka commented Jan 15, 2019 •
edited
Loading

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.

@tpazderka tpazderka mentioned this pull request Jan 15, 2019
Closed
2 tasks
@tpazderka tpazderka requested a review from rohe January 15, 2019 19:47
@tpazderka
Copy link
Collaborator Author

The only changes apart from your PR @rohe is the separation of getting the data from cookie and an extra test with a wrong cookie to get full coverage on testing.

Otherwise it should be the same (small quality fixes).

@rohe rohe merged commit 65e6f7f into master Jan 17, 2019
@rohe rohe deleted the client_id_in_cookie branch January 17, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohe rohe rohe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpazderka @rohe