Bunjiboys jwks content type #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpazderka
force-pushed
the
bunjiboys-jwks-content-type
branch
from
bf53855
to
59f4df1
Compare
2 tasks
schlenk
approved these changes
Jan 12, 2019
src/oic/utils/keyio.py
Outdated
| @@ -222,7 +222,7 @@ def _parse_remote_response(self, response): | |||
| """ | |||
| # Check if the content type is the right one. | |||
| try: | |||
| if response.headers["Content-Type"] != 'application/json': | |||
| if not response.headers["Content-Type"].startswith('application/json'): | |||
There was a problem hiding this comment.
That header part 'application/json' is case insensitive (RFC 7231 3.1.1.1)
So unless response.headers normalizes it, this might fail for some strange responses.
There was a problem hiding this comment.
Yes, that is correct. requests do not normalize the value of the header, just the key.
We are not doing much of a content type comparison, so I will add lower here.
tpazderka
force-pushed
the
bunjiboys-jwks-content-type
branch
from
59f4df1
to
20d984a
Compare
tpazderka
force-pushed
the
bunjiboys-jwks-content-type
branch
from
20d984a
to
de86147
Compare
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
==========================================
+ Coverage 60.18% 60.24% +0.05%
==========================================
Files 62 62
Lines 11266 11266
Branches 1985 1985
==========================================
+ Hits 6781 6787 +6
+ Misses 3930 3924 -6
Partials 555 555
Continue to review full report at Codecov.
|
mblomdahl
added a commit
to mkdevops-se/pyoidc
that referenced
this pull request
Feb 22, 2019
andrewkrug
pushed a commit
to mozilla-iam/pyoidc
that referenced
this pull request
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md.