Fixed installer.lua behavior when initializing fLoc and fPath on Windows #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing
fLocandfPathon Windows, it was assumed that%USERPROFILE%ends with a backslash, which it does not. As a result, Windows users experienced issues where installing a new theme would lead to the following error:Therefore, the modifications I made on lines
51and137now create the expected path.This fix has been tested on Neovim
0.9.5and Windows 11. If%USERPROFILE%does end with a backslash on some PCs, it will not cause issues as both//and/are interpreted correctly on Windows.