Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin Numpy #218

Open
kylebgorman opened this issue Jul 29, 2024 · 1 comment · May be fixed by #265
Open

Unpin Numpy #218

kylebgorman opened this issue Jul 29, 2024 · 1 comment · May be fixed by #265
Assignees
@kylebgorman
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kylebgorman
Copy link
Contributor

#202 pinned numpy to < 2 because there was a conflict with PyTorch. This serves a reminder to remove this pin: most likely we can set numpy > 2.x.y (tbd) and also do the same for torch > 2.a.b. (also tbd) once the conflict is worked out. In fact this might already be possible.
@kylebgorman kylebgorman added enhancement New feature or request good first issue Good for newcomers labels Jul 29, 2024
@kylebgorman kylebgorman self-assigned this Jul 29, 2024
@kylebgorman
Copy link
Contributor Author

I did some research and the issue in question is PyTorch-Lightning. Presumably once we migrate onto >= 2.0.0 as per #60, we can release the pin.

kylebgorman added a commit to kylebgorman/yoyodyne that referenced this issue Nov 20, 2024
@kylebgorman
Migrates to LightningCLI.
0f9b7a7 
Closes CUNY-CL#60.
Closes CUNY-CL#218.

LightningCLI removes our need to create separate training and prediction
CLI programs, moving nearly all of that logic into the base model.

This commit in particular sets the stage:

* Updates dependencies.
* Increments minor version number.
* Creates an empty `cli.py` where the CLI-speific logic will live.
@kylebgorman kylebgorman linked a pull request Nov 20, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylebgorman kylebgorman

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrates to LightningCLI kylebgorman/yoyodyne
1 participant
@kylebgorman