Fixes excessive line wrapping. #529
Conversation
It seems that Min Nan has been totally removed from English Wiktionary.
There was a problem hiding this comment.
Looks great overall. A small merge conflict for CHANGELOG.md needs to be resolved. I also have a question about "lxml_html_clean".
The Min Nan nan smoke test is broken. It seems that Min Nan has been removed from English Wiktionary, without a trace. So, I have proposed to delete its custom selector. @jacksonllee if you have a moment, could you make sure I'm not making things worse? (Is it perhaps now recorded as Hokkien or Fujian?)
Everything looks right to me with respect to dropping Min Nan here. Hokkien would be a good addition, but it currently has only 74 entries on Wiktionary. When it reaches our threshold of 100, we can pull in the data.
| @@ -1,7 +1,8 @@ | |||
| ipapy>=0.0.9.0 | |||
| lxml_html_clean | |||
There was a problem hiding this comment.
Were you trying to use lxml_html_clean somewhere? It's not used in this pull request.
There was a problem hiding this comment.
The Min Nan
nansmoke test is broken. It seems that Min Nan has been removed from English Wiktionary, without a trace. So, I have proposed to delete its custom selector. @jacksonllee if you have a moment, could you make sure I'm not making things worse? (Is it perhaps now recorded as Hokkien or Fujian?)UnreleasedinCHANGELOG.mdto reflect the changes in code or data.