-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --restriction flag #154
Conversation
… with --restriction flag.
Cool! I'm going to add @lfashby to review; looks basically right but maybe some style issues. Could you type
Could you add "Closes #153" to the PR itself? That'll cause GitHub to automatically close the issue when/if this is merged. |
Also do add this to the CHANGELOG as detailed above, and check the check-box when you do. |
Probably should add a line to |
|
I think this looks alright. There is only one thing I would add in addition to Kyle's comments. For the record, I'm not convinced that the big scrape should have this sort of functionality. I guess if it makes our lives easier (with respect to testing how WikiPron works on a subset of languages) then it is fine to have, but it doesn't address the currently awkward part of running a big scrape -- having to manually find the languages WikiPron failed on during the big scrape and then restricting |
… --restriction arguments. Also fixed bug that would log error if argument began with whitespace. README updated to indicate for using subsets for 'big scrape.'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #153
Two nits left then we're ready. I am looking forward to having this around. To reflow on this project we use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving (tho note note about out-of-date comment). Thanks for this!
Added --restriction flag to limit 'big scrape' to individual languages. Can specify one or more languages to scrape by following flag with ISO codes of desired languages.
Unreleased
inCHANGELOG.md
to reflect the changes in code or data.