-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some language codes not recognized by iso639.Language.match() #498
Comments
I hadn't seen that fatal exception before. I think we should probably catch it and convert it to a warning. What do you think? |
Giving a warning sounds like a good idea. In place of try:
iso639_lang = iso639.Language.match(wiktionary_code)
except iso639.language.LanguageNotFoundError:
logging.warning(
"Could not find language with code %s", wiktionary_code
) ... so that in the case of
|
This proposal LGTM. |
Fixed issue in [issue CUNY-CL#498](CUNY-CL#498) The iso639 module occasionally doesn't recognizing ISO language codes. Updated the code to catch this error and display a warning.
Closed in #499, I believe. |
Running codes.py yielded the following error:
For whatever reason, the iso639 module isn't recognizing some of the language codes from the wiktionary API. Someone should look into why this is, or maybe omit languages that don't have valid language codes.
The text was updated successfully, but these errors were encountered: