Adds inactive request protection to Firestore *Once methods #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrtnkb Thanks for this, I've just done some testing and all looks good! I'll get this merged and then look to back port it to the v4.0.x branch so that it can be released in that stream of work rather than wait for v5 which is going to need some more testing. |
chrisbianca
added a commit
that referenced
this pull request
Jan 11, 2022
|
v5 is now released too: https://github.com/CSFrequency/react-firebase-hooks/releases/tag/v5.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to results being returned asynchronously, Firestore use*Once methods are susceptible to race conditions when queries change.
This PR adds protection to ensure that setValue and setError are only called for results matching the current request.
See issue #194 for more details.