Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Firebase beta deployment release job #90

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

philippzagar
Copy link
Contributor

Remove firebase beta deployment

♻️ Current situation & Problem

As of now, the release pipeline fails as no Firebase project file is present anymore in the project. However, the Firebase deployment step is not required, we can remove this release job all together.

⚙️ Release Notes

  • Remove Firebase beta deployment release job

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Apr 1, 2024
@philippzagar philippzagar self-assigned this Apr 1, 2024
Copy link
Contributor

@kcallon kcallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@philippzagar philippzagar enabled auto-merge (squash) April 1, 2024 04:06
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.89%. Comparing base (f9689d7) to head (304c56a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   49.89%   49.89%           
=======================================
  Files          51       51           
  Lines        3083     3083           
=======================================
  Hits         1538     1538           
  Misses       1545     1545           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9689d7...304c56a. Read the comment docs.

@philippzagar philippzagar merged commit a859470 into main Apr 1, 2024
7 checks passed
@philippzagar philippzagar deleted the feat/remove-firebase-deployment branch April 1, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants