Small fix for EMPairProduction when haveElectrons=False and small Optimizations #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dary injection can be applied and no other calculations are done in that case, that should be not necessary
rafaelab
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear all,
@lukasmerten , @JulienDoerner and me discussed a possible fix of #488 and thought of opening this very small PR.
We switched the order of the lines in EMPairProduction.cpp that in the current master-version would prevent the catastrophic energy loss of the pairproduction in the case of haveElectrons=False.
We also noticed two very small optimizations that could be done in EMDoublePairProduction.cpp and EMInverseComptonScattering.cpp that we included in this PR, that do not affect the physics and could lead to a little speedup in the runtime of the modules.
Thank you in advance!