Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable wk cookie store #171

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Enable wk cookie store #171

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1580336
Added Cookie Handling
Jul 16, 2018
d54fd07
added missing Method
Jul 17, 2018
232de7e
Added new useWKCookieStore option
Jul 24, 2018
7f2e56d
clean spaces
jigfox Aug 15, 2018
3c8c29d
Set cookie from cookiesWithResponseHeaderFields
whck6 Apr 26, 2018
0dd8f06
remove spaces
jigfox Oct 1, 2018
1c08e36
remove duplicated method
jigfox Oct 1, 2018
8d4382e
add Secure and HttpOnly flags to cookie
jigfox Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 19 additions & 22 deletions ios/RCTWKWebView/RCTWKWebView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,15 +513,27 @@ - (void)scrollViewDidScroll:(UIScrollView *)scrollView
#pragma mark - WKNavigationDelegate methods

- (void)webView:(WKWebView *)webView decidePolicyForNavigationResponse:(WKNavigationResponse *)navigationResponse decisionHandler:(void (^)(WKNavigationResponsePolicy))decisionHandler {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are duplicate methods with this same name, can you please fix this? This is breaking my build with compilation issue

if (_sendCookies) {
NSHTTPURLResponse *response = (NSHTTPURLResponse *)navigationResponse.response;
NSArray *cookies = [NSHTTPCookie cookiesWithResponseHeaderFields:[response allHeaderFields] forURL:response.URL];
for (NSHTTPCookie *cookie in cookies) {
[[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookie:cookie];
}
if (_sendCookies) {
NSHTTPURLResponse *response = (NSHTTPURLResponse *)navigationResponse.response;
NSArray *cookies = [NSHTTPCookie cookiesWithResponseHeaderFields:[response allHeaderFields] forURL:response.URL];
for (NSHTTPCookie *cookie in cookies) {
[[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookie:cookie];
}
}

decisionHandler(WKNavigationResponsePolicyAllow);
if (_onNavigationResponse) {
NSDictionary *headers = ((NSHTTPURLResponse *)navigationResponse.response).allHeaderFields;
NSInteger statusCode = ((NSHTTPURLResponse *)navigationResponse.response).statusCode;
NSMutableDictionary<NSString *, id> *event = [self baseEvent];
[event addEntriesFromDictionary:@{
@"headers": headers,
@"status": [NSHTTPURLResponse localizedStringForStatusCode:statusCode],
@"statusCode": @(statusCode),
}];
_onNavigationResponse(event);
}

decisionHandler(WKNavigationResponsePolicyAllow);
}

#if DEBUG
Expand Down Expand Up @@ -678,20 +690,5 @@ - (void)webViewWebContentProcessDidTerminate:(WKWebView *)webView
RCTLogWarn(@"Webview Process Terminated");
}

- (void)webView:(WKWebView *)webView decidePolicyForNavigationResponse:(WKNavigationResponse *)navigationResponse decisionHandler:(void (^)(WKNavigationResponsePolicy))decisionHandler {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response. Appreciate it

if (_onNavigationResponse) {
NSDictionary *headers = ((NSHTTPURLResponse *)navigationResponse.response).allHeaderFields;
NSInteger statusCode = ((NSHTTPURLResponse *)navigationResponse.response).statusCode;
NSMutableDictionary<NSString *, id> *event = [self baseEvent];
[event addEntriesFromDictionary:@{
@"headers": headers,
@"status": [NSHTTPURLResponse localizedStringForStatusCode:statusCode],
@"statusCode": @(statusCode),
}];
_onNavigationResponse(event);
}

decisionHandler(WKNavigationResponsePolicyAllow);
}

@end