Skip to content

Conversation

@aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Nov 11, 2025

  • Use python 3.10 when testing the lowest possible dependencies (fixes an error with pytket not being found for py3.14)
  • Get the cached tket-c-api before calling maturin build

CI run: https://github.com/CQCL/tket2/actions/runs/19262256076

@aborgna-q aborgna-q requested a review from a team as a code owner November 11, 2025 10:06
@aborgna-q aborgna-q requested review from cqc-alec and doug-q and removed request for doug-q November 11, 2025 10:06
@cqc-alec
Copy link
Collaborator

Do you know why the "Release Checks" workflow was skipped? Looks like it should run for every PR to main?

@aborgna-q
Copy link
Collaborator Author

We only run it for tket-py release PRs (#976).

We are checking that the tket version in main works with the latest releases of tket-exts and tket-eccs.
That's not always the case, as we may have unpublished breaking changes to those.

We only need to check for that when actually preparing to make a release.

@cqc-alec
Copy link
Collaborator

But currently (since #1016 ) it looks like it should run on all PRs? Confused.

Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still puzzled why this isn't working with python 3.14.

@aborgna-q
Copy link
Collaborator Author

aborgna-q commented Nov 11, 2025

But currently (since #1016 ) it looks like it should run on all PRs? Confused.

The actual step has an if condition, because we cannot filter by PR branch name on the triggers.

if: ${{ github.event_name == 'workflow_dispatch' || github.head_ref == 'release-please--branches--main--components--tket-py' }}

Still puzzled why this isn't working with python 3.14.

The lower check uses the minimum bounds for each direct dependency, so for pytket it was fetching 1.34.0, which didn't have abi3 or 3.14 wheels.

https://github.com/CQCL/tket2/actions/runs/19241911253/job/55006437818?pr=1238#step:6:57

@aborgna-q aborgna-q added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main with commit cf1ffae Nov 11, 2025
25 checks passed
@aborgna-q aborgna-q deleted the ab/release-checks branch November 11, 2025 10:48
@cqc-alec
Copy link
Collaborator

Ah I see, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants