Skip to content

Conversation

@aborgna-q
Copy link
Collaborator

No description provided.

@aborgna-q aborgna-q requested a review from a team as a code owner November 10, 2025 10:47
@aborgna-q aborgna-q requested a review from cqc-alec November 10, 2025 10:47
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.71%. Comparing base (e0771f8) to head (be86b6c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1230      +/-   ##
==========================================
- Coverage   78.75%   78.71%   -0.04%     
==========================================
  Files         160      160              
  Lines       20592    20592              
  Branches    19490    19490              
==========================================
- Hits        16217    16210       -7     
- Misses       3387     3392       +5     
- Partials      988      990       +2     
Flag Coverage Δ
python 92.65% <ø> (ø)
rust 78.35% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugrbot
Copy link
Collaborator

hugrbot commented Nov 10, 2025

This PR contains breaking changes to the public Rust API.
Please deprecate the old API instead (if possible), or mark the PR with a ! to indicate a breaking change.

cargo-semver-checks summary
    Building tket v0.16.0 (current)
     Built [  43.381s] (current)
   Parsing tket v0.16.0 (current)
    Parsed [   0.096s] (current)
  Building tket v0.16.0 (baseline)
     Built [  41.530s] (baseline)
   Parsing tket v0.16.0 (baseline)
    Parsed [   0.082s] (baseline)
  Checking tket v0.16.0 -> v0.16.0 (assume minor change)
   Checked [   0.077s] 159 checks: 157 pass, 2 fail, 0 warn, 41 skip

--- failure auto_trait_impl_removed: auto trait no longer implemented ---

Description:
A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented.
      ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/auto_trait_impl_removed.ron

Failed in:
type EncodedCircuit is no longer UnwindSafe, in /home/runner/work/tket2/tket2/PR_BRANCH/tket/src/serialize/pytket/circuit.rs:40
type EncodedCircuit is no longer RefUnwindSafe, in /home/runner/work/tket2/tket2/PR_BRANCH/tket/src/serialize/pytket/circuit.rs:40

--- failure enum_struct_variant_field_added: pub enum struct variant field added ---

Description:
An enum's exhaustive struct variant has a new field, which has to be included when constructing or matching on this variant.
      ref: https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_struct_variant_field_added.ron

Failed in:
field params of variant PytketEncodeError::UnsupportedSubgraphHasNoRegisters in /home/runner/work/tket2/tket2/PR_BRANCH/tket/src/serialize/pytket/error.rs:109

   Summary semver requires new major version: 2 major and 0 minor checks failed
  Finished [  87.157s] tket
  Building tket-qsystem v0.22.0 (current)
     Built [  42.838s] (current)
   Parsing tket-qsystem v0.22.0 (current)
    Parsed [   0.029s] (current)
  Building tket-qsystem v0.22.0 (baseline)
     Built [  42.957s] (baseline)
   Parsing tket-qsystem v0.22.0 (baseline)
    Parsed [   0.028s] (baseline)
  Checking tket-qsystem v0.22.0 -> v0.22.0 (assume minor change)
   Checked [   0.042s] 159 checks: 159 pass, 41 skip
   Summary no semver update required
  Finished [  87.818s] tket-qsystem

@aborgna-q aborgna-q added this pull request to the merge queue Nov 10, 2025
Merged via the queue into main with commit 01b8a8e Nov 10, 2025
22 of 24 checks passed
@aborgna-q aborgna-q deleted the ab/bump-hugr-0.24.3 branch November 10, 2025 11:01
github-merge-queue bot pushed a commit that referenced this pull request Nov 10, 2025
Looks like #1230 changed the snapshots, but my local wheel cache didn't
update.

This PR includes some fixes:
- Update the pytest snapshots of qis-compiler, with the changes arising
from CQCL/hugr#2666 and published in `hugr
0.23.4`.
- Ensures that the required CI checks fail if `tests-qis-compiler`
fails. (And makes sure we don't omit new requirements again).
- Adds `update-snapshots-py` to the justfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants