chore: release #2667
Closed
chore: release #2667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2667 +/- ##
=======================================
Coverage 83.46% 83.46%
=======================================
Files 262 262
Lines 51297 51297
Branches 46858 46858
=======================================
Hits 42813 42813
Misses 6105 6105
Partials 2379 2379
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. π New features to boost your workflow:
|
aborgna-q
requested review from
a team,
aborgna-q,
cqc-alec,
doug-q and
ss2165
as code owners
aborgna-q
approved these changes
Nov 6, 2025
cqc-alec
approved these changes
Nov 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a manual request
|
? |
github-merge-queue bot
pushed a commit
to CQCL/tket2
that referenced
this pull request
Nov 6, 2025
This PR is a compilation of fixes to the pytket encoder/decoder. With these implemented, the example from CQCL/hugr#2667 should work correctly. The fixes include (one per commit): - Marking wires that carry no value as unsupported, since they cannot be attached to a pytket operation. (They will instead be included in an opaque subgraph / barrier op). - Don't use `SiblingSubgraph` to define the unsupported subgraphs. That structure is quite opinionated and brittle; - it doesn't support non-value edges in the boundaries - it has a complex definition for mapping between boundary ports and actual node ports (unnecessary in this case) - requires running an expensive convexity checker on each instantiation, even when we know the set of nodes is valid - and other annoyances - Mark any node with order edges as unsupported (so we don't lose those the edges the pytket roundtrip) - Fix issue with bits not appearing in the input/output missing from the pytket circuit's list - Add an initial hardcoded translator between native booleans and tket booleans, with a TODO to make the system extensible. - Avoid `QAlloc`ing qubits that don't get consumed afterwards. - Ensure we give loaded output parameters the correct type. - Don't try to encode wires with complex types that include parameters like `[float]` / `[float, rotation]`. - Store input parameters to `extra_subgraph` (that cannot be encoded in the pytket circuit) The main result is a bunch of tests now passing in `tests.rs`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π€ New release
hugr-model: 0.24.2 -> 0.24.3hugr-core: 0.24.2 -> 0.24.3hugr-llvm: 0.24.2 -> 0.24.3 (β API compatible changes)hugr-passes: 0.24.2 -> 0.24.3 (β API compatible changes)hugr: 0.24.2 -> 0.24.3 (β API compatible changes)hugr-cli: 0.24.2 -> 0.24.3hugr-persistent: 0.3.3 -> 0.3.4Changelog
hugr-modelhugr-corehugr-llvmhugr-passeshugrhugr-clihugr-persistentThis PR was generated with release-plz.