fix: added public func getter for EmitFuncContext #2482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
=======================================
Coverage 82.66% 82.67%
=======================================
Files 251 251
Lines 46599 46612 +13
Branches 42160 42173 +13
=======================================
+ Hits 38521 38535 +14
+ Misses 6028 6027 -1
Partials 2050 2050
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
For the CI errors:
|
jennyQuantinuum
changed the title
jennyQuantinuum
force-pushed
the
jenny/deadcode_issue
branch
from
ae211c7 to
06bc080
Compare
cqc-alec
approved these changes
Jul 29, 2025
qartik
approved these changes
Jul 29, 2025
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 6, 2025
## 🤖 New release
* `hugr-model`: 0.22.1 -> 0.23.0 (✓ API compatible changes)
* `hugr-core`: 0.22.1 -> 0.23.0 (⚠ API breaking changes)
* `hugr-llvm`: 0.22.1 -> 0.23.0 (✓ API compatible changes)
* `hugr-passes`: 0.22.1 -> 0.23.0 (✓ API compatible changes)
* `hugr-persistent`: 0.2.1 -> 0.2.2 (✓ API compatible changes)
* `hugr`: 0.22.1 -> 0.23.0 (✓ API compatible changes)
* `hugr-cli`: 0.22.1 -> 0.23.0 (✓ API compatible changes)
### ⚠ `hugr-core` breaking changes
```text
--- failure struct_missing: pub struct removed or renamed ---
Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/struct_missing.ron
Failed in:
struct hugr_core::hugr::views::sibling_subgraph::TopoConvexChecker, previously in file /tmp/.tmpA42bjc/hugr-core/src/hugr/views/sibling_subgraph.rs:601
```
<details><summary><i><b>Changelog</b></i></summary><p>
## `hugr-model`
<blockquote>
##
[0.23.0](hugr-model-v0.22.1...hugr-model-v0.23.0)
- 2025-08-06
### New Features
- Type of constants in `core` `Term`s.
([#2411](#2411))
</blockquote>
## `hugr-core`
<blockquote>
##
[0.23.0](hugr-core-v0.22.1...hugr-core-v0.23.0)
- 2025-08-06
### New Features
- Type of constants in `core` `Term`s.
([#2411](#2411))
- Support LineConvexChecker
([#2487](#2487))
</blockquote>
## `hugr-llvm`
<blockquote>
##
[0.23.0](hugr-llvm-v0.22.1...hugr-llvm-v0.23.0)
- 2025-08-06
### Bug Fixes
- added public func getter for EmitFuncContext
([#2482](#2482))
- *(hugr-llvm)* Set llvm function linkage based on Visibility hugr node
field ([#2502](#2502))
</blockquote>
## `hugr-passes`
<blockquote>
##
[0.22.1](hugr-passes-v0.22.0...hugr-passes-v0.22.1)
- 2025-07-28
### New Features
- Include copy_discard_array in DelegatingLinearizer::default
([#2479](#2479))
- Inline calls to functions not on cycles in the call graph
([#2450](#2450))
</blockquote>
## `hugr-persistent`
<blockquote>
##
[0.2.0](hugr-persistent-v0.1.0...hugr-persistent-v0.2.0)
- 2025-07-24
### New Features
- [**breaking**] Update portgraph dependency to 0.15
([#2455](#2455))
</blockquote>
## `hugr`
<blockquote>
##
[0.23.0](hugr-v0.22.1...hugr-v0.23.0)
- 2025-08-06
### New Features
- Type of constants in `core` `Term`s.
([#2411](#2411))
- Support LineConvexChecker
([#2487](#2487))
</blockquote>
## `hugr-cli`
<blockquote>
##
[0.23.0](hugr-cli-v0.22.1...hugr-cli-v0.23.0)
- 2025-08-06
### New Features
- *(cli)* Deprecate HugrInputArgs::get_hugr
([#2506](#2506))
</blockquote>
</p></details>
---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
---------
Co-authored-by: Luca Mondada <[email protected]>
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 15, 2025
## 🤖 New release * `hugr-model`: 0.22.2 -> 0.22.3 (✓ API compatible changes) * `hugr-core`: 0.22.2 -> 0.22.3 (✓ API compatible changes) * `hugr-llvm`: 0.22.2 -> 0.22.3 (✓ API compatible changes) * `hugr-passes`: 0.22.2 -> 0.22.3 (✓ API compatible changes) * `hugr-persistent`: 0.2.2 -> 0.2.3 (✓ API compatible changes) * `hugr`: 0.22.2 -> 0.22.3 (✓ API compatible changes) * `hugr-cli`: 0.22.2 -> 0.22.3 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr-model` <blockquote> ## [0.22.2](hugr-model-v0.22.1...hugr-model-v0.22.2) - 2025-08-06 ### New Features - Type of constants in `core` `Term`s. ([#2411](#2411)) </blockquote> ## `hugr-core` <blockquote> ## [0.22.3](hugr-core-v0.22.2...hugr-core-v0.22.3) - 2025-09-11 ### Bug Fixes - SiblingSubgraph::try_from_nodes not including disconnected components ([#2549](#2549)) ### Documentation - Clarify docs for SiblingSubgraph::{inputs, outputs} ([#2508](#2508)) ### New Features - SiblingSubgraph supports function calls ([#2528](#2528)) - Add unchecked constructor for SiblingSubgraph ([#2526](#2526)) - Add HugrMut::insert(_view)_forest ([#2518](#2518)) - Add extend_inputs function for DFGs ([#2536](#2536)) - Loosen bound on Patch trait ([#2545](#2545)) </blockquote> ## `hugr-llvm` <blockquote> ## [0.22.2](hugr-llvm-v0.22.1...hugr-llvm-v0.22.2) - 2025-08-06 ### Bug Fixes - added public func getter for EmitFuncContext ([#2482](#2482)) - *(hugr-llvm)* Set llvm function linkage based on Visibility hugr node field ([#2502](#2502)) </blockquote> ## `hugr-passes` <blockquote> ## [0.22.3](hugr-passes-v0.22.2...hugr-passes-v0.22.3) - 2025-09-11 ### New Features - SiblingSubgraph supports function calls ([#2528](#2528)) </blockquote> ## `hugr-persistent` <blockquote> ## [0.2.3](hugr-persistent-v0.2.2...hugr-persistent-v0.2.3) - 2025-09-11 ### Documentation - Clarify docs for SiblingSubgraph::{inputs, outputs} ([#2508](#2508)) ### New Features - SiblingSubgraph supports function calls ([#2528](#2528)) </blockquote> ## `hugr` <blockquote> ## [0.22.3](hugr-v0.22.2...hugr-v0.22.3) - 2025-09-11 ### Bug Fixes - SiblingSubgraph::try_from_nodes not including disconnected components ([#2549](#2549)) ### Documentation - Clarify docs for SiblingSubgraph::{inputs, outputs} ([#2508](#2508)) ### New Features - SiblingSubgraph supports function calls ([#2528](#2528)) - Add unchecked constructor for SiblingSubgraph ([#2526](#2526)) - Add extend_inputs function for DFGs ([#2536](#2536)) - Loosen bound on Patch trait ([#2545](#2545)) - Add HugrMut::insert(_view)_forest ([#2518](#2518)) </blockquote> ## `hugr-cli` <blockquote> ## [0.22.3](hugr-cli-v0.22.2...hugr-cli-v0.22.3) - 2025-09-11 ### New Features - *(hugr-cli)* CliError::validate helper ([#2507](#2507)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/quantinuum-dev/eldarion/issues/360
Enables:
This PR adds a public func getter for EmitFuncContext to enable tket2 qsystem to access the FunctionValue and sets linkage to Private for all the qsystem helper functions.
Other Notes: