fix: Remove deleted nodes from node_map in SimpleReplacement
#2176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2176 +/- ##
==========================================
+ Coverage 82.09% 82.13% +0.03%
==========================================
Files 227 227
Lines 39802 39760 -42
Branches 35901 35859 -42
==========================================
- Hits 32677 32656 -21
+ Misses 5303 5282 -21
Partials 1822 1822
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aborgna-q
approved these changes
May 9, 2025
| for &child in &replace_children[2..] { | ||
|
|
||
| // make all (remaining) replacement top level children children of the parent | ||
| for child in h.children(new_entrypoint).collect_vec() { |
Collaborator
There was a problem hiding this comment.
Suggested change
| for child in h.children(new_entrypoint).collect_vec() { | |
| for child in h.children(new_entrypoint) { |
Contributor
Author
There was a problem hiding this comment.
no, I've had to collect because h is mutated in the loop body
This was referenced May 9, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.