feat: InsertCut patch for inserting HUGR across edges. #2153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
requested review from
jake-arkinstall and
zrho
and removed request for
jake-arkinstall and
zrho
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2153 +/- ##
==========================================
- Coverage 82.17% 82.17% -0.01%
==========================================
Files 227 228 +1
Lines 39904 39965 +61
Branches 36003 36064 +61
==========================================
+ Hits 32790 32840 +50
- Misses 5284 5294 +10
- Partials 1830 1831 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ss2165
force-pushed
the
ss/insert-cut
branch
2 times, most recently
from
0c9390f to
ec16c63
Compare
aborgna-q
force-pushed
the
release-rs-v0.16.0
branch
from
56c110c to
9cd24ff
Compare
test invalidation set format
zrho
approved these changes
May 7, 2025
| pub parent: N, | ||
| /// The targets of the existing edges. | ||
| pub targets: Vec<(N, IncomingPort)>, | ||
| /// The HUGR to insert, must have DFG parent. |
This was referenced May 8, 2025
Closed
Closed
github-merge-queue bot
pushed a commit
to CQCL/tket2
that referenced
this pull request
May 19, 2025
#866) Closes #853 Closes #865 ~Blocked by hugr release including [InsertCut](CQCL/hugr#2153 Barriers exist across arbitrary types. To make sure scheduling respects this at runtime, when lowering we follow it with a `RuntimeBarrier` across a generically sized array of qubits. To do this the lowering unpacks qubits from the barrier type row, applies the runtime barrier, then repacks them in to the original types. Arrays and tuples containing qubits are recursively unpacked. Sums of qubits are ignored except in the special case of arrays of option of qubits, wherein it is assumed all qubits are present (when generated by guppy this is guaranteed). For each concrete container type a temporary extension is used to add unpacking and re-packing operations. These are later lowered to calls to functions that implement the operations. BREAKING CHANGE: `QSystemOpBuilder` gained supertrait `ArrayOpBuilder` --------- Co-authored-by: Douglas Wilson <[email protected]> Co-authored-by: Mark Koch <[email protected]> Co-authored-by: Agustín Borgna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.