-
Notifications
You must be signed in to change notification settings - Fork 13
fix!: Don't expose HugrMutInternals
#2071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Added to the next breaking-change milestone |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-rs-v0.16.0 #2071 +/- ##
=====================================================
Coverage ? 82.90%
=====================================================
Files ? 217
Lines ? 41534
Branches ? 37712
=====================================================
Hits ? 34435
Misses ? 5295
Partials ? 1804
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
d76a3cc to
6489456
Compare
`HugrMutInternals` is part of the semi-private traits defined in `hugr-core`. While most things get re-exported in `hugr`, we `*Internal` traits require you to explicitly declare a dependency on the `-core` package (as we don't want most users to have to interact with them). For some reason there was a public re-export of the trait in a re-exported module, so it ended up appearing in `hugr` anyways. BREAKING CHANGE: Removed public re-export of `HugrMutInternals` from `hugr`.
HugrMutInternalsis part of the semi-private traits defined inhugr-core.While most things get re-exported in
hugr, we*Internaltraits require you to explicitly declare a dependency on the-corepackage (as we don't want most users to have to interact with them).For some reason there was a public re-export of the trait in a re-exported module, so it ended up appearing in
hugranyways.BREAKING CHANGE: Removed public re-export of
HugrMutInternalsfromhugr.