chore!: Require a context when converting types to Hugr #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
==========================================
- Coverage 92.33% 92.32% -0.02%
==========================================
Files 103 103
Lines 10186 10250 +64
==========================================
+ Hits 9405 9463 +58
- Misses 781 787 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Actually, I'm not sure if this is really needed. @acl-cqc maybe hold off on reviewing this until I've thought a bit more about this |
Collaborator
Author
|
@acl-cqc This is ready for review now |
mark-koch
changed the title
ss2165
approved these changes
Jun 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
Closes #1035. Tracked PRs: * #1022 * #1034 * #1035 BREAKING CHANGE: All `to_hugr` methods on types, arguments, and parameters now require a `ToHugrContext` BREAKING CHANGE: `CompileableDef.compile_outer` now requires a `ToHugrContext` BREAKING CHANGE: `guppy.hugr_op` now passes the compiler context to the function generating the op BREAKING CHANGE: `CheckedFunctionDef` now implements `MonomorphizableDef` instead of `CompileableDef` BREAKING CHANGE: `CompilerContext.build_compiled_def` now requires an instantiation for the definition's type parameters BREAKING CHANGE: The `ToHugrContext` protocol now requires two additional methods: `type_var_to_hugr` and `const_var_to_hugr` BREAKING CHANGE: `CompilerContext.{compiled, worklist}` and `CompilationEngine.compiled` are now indexed by a tuple of `DefId` and optional `PartiallyMonomorphizedArgs` --------- Co-authored-by: Alan Lawrence <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required as a precusor to #1018 to handle monomorphisation: When compiling to Hugr, some bound type variables will need to be replaced with a monotype. We will need access to the compiler context to look this information up.
Instead of requiring the whole compiler context, I added a new
ToHugrContextprotocol in which we can put everything that is needed during the Hugr translation of types (empty for now but will be filled in a subsequent PR). The main motivation for this is that the context needs to change when we go under a binder.BREAKING CHANGE: All
to_hugrmethods on types, arguments, and parameters now require aToHugrContextBREAKING CHAGNE:
CompileableDef.compile_outernow requires aToHugrContextBREAKING CHANGE:
guppy.hugr_opnow passes the compiler context to the function generating the op