Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mei export Updates #351

Merged
merged 30 commits into from
Mar 11, 2024
Merged

Mei export Updates #351

merged 30 commits into from
Mar 11, 2024

Conversation

manoskary
Copy link
Member

This PR solves some relatively important issues that were overlooked with MEI export.

  • Added important support for dotted notes.
  • Added Cadence Class and visualization in the export.
  • Added support for Beams in MusicXML which will nicely visualize and export beams in MEI.
  • Added support for barlines, title and fermata
  • Added a function to infer beams
  • Updated rest infilling.
  • Added support for cross-staff beaming.

Thank you.

@manoskary manoskary changed the title Mei export v2 Mei export Updates Mar 1, 2024
@manoskary manoskary self-assigned this Mar 1, 2024
@manoskary manoskary added the enhancement New feature or request label Mar 1, 2024
@manoskary manoskary added this to In progress in Release 1.5.0 via automation Mar 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 33.21678% with 191 lines in your changes are missing coverage. Please review.

Project coverage is 84.11%. Comparing base (018f264) to head (8de77aa).
Report is 1 commits behind head on develop.

Files Patch % Lines
partitura/score.py 10.00% 144 Missing ⚠️
partitura/io/exportmei.py 52.12% 45 Missing ⚠️
partitura/io/importmusicxml.py 96.55% 1 Missing ⚠️
partitura/utils/music.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #351      +/-   ##
===========================================
- Coverage    84.96%   84.11%   -0.86%     
===========================================
  Files           82       82              
  Lines        14236    14506     +270     
===========================================
+ Hits         12096    12202     +106     
- Misses        2140     2304     +164     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fosfrancesco fosfrancesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding functionalities for Cadence display, and correcting some problems in MEI export

@manoskary manoskary merged commit 3cd1e41 into develop Mar 11, 2024
3 checks passed
Release 1.5.0 automation moved this from In progress to Done Mar 11, 2024
@manoskary manoskary mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants