mei measure number is now an integer, and. Measure.name is the string…

[fosfrancesco]

Fixed a problem with Measure elements in MEI loading.
Now measure has 2 attributes:

• number: an integer, from 0, which increase at each measure
• name: the string how is encoded by the person writing the score (it may start from 1 or have strings inside)

[codecov-commenter]

Codecov Report

Patch coverage: 73.07% and project coverage change: +0.01% 🎉

Comparison is base (5fe996d) 85.13% compared to head (cc28af0) 85.14%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #310      +/-   ##
===========================================
+ Coverage    85.13%   85.14%   +0.01%     
===========================================
  Files           80       80              
  Lines        13663    13673      +10     
===========================================
+ Hits         11632    11642      +10     
  Misses        2031     2031              

Files Changed	Coverage Δ
partitura/io/musescore.py	27.47% <0.00%> (ø)
partitura/utils/music.py	74.20% <ø> (ø)
partitura/io/importmei.py	92.19% <84.61%> (+0.03%)	⬆️
tests/test_mei.py	99.52% <100.00%> (+0.01%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gregchapman-dev]

Can I recommend the name "index" instead of "number"?

[fosfrancesco]

I think it is a good proposal to avoid confusion.

But this will need to be addressed in a separate pull request since we will need to update it also for all the other parsers, and some functions like measure_number_map. I will open an issue for remembering and for discussion.

The goal of this pull request is to have the same behaviour as the musicxml parser.

[huispaty]

The suggested change works and corresponds to how we parse measures in musicxml.
The Measure object has the number and name attributes. Currently, the number attribute represents a running count of measures (tags), irrespective of their regularity or volta endings - thus it starts at 1 and continuously increments. However, we could also interpret number more akin to an index (as suggested here) - and rename it to index accordingly. Let me know what you prefer.

[fosfrancesco]

I found a bug with volta measures and corrected it. I would need new approval. Thank you!