-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mei measure number is now an integer, and. Measure.name is the string… #310
Conversation
… saved in the score
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #310 +/- ##
===========================================
+ Coverage 85.13% 85.14% +0.01%
===========================================
Files 80 80
Lines 13663 13673 +10
===========================================
+ Hits 11632 11642 +10
Misses 2031 2031
☔ View full report in Codecov by Sentry. |
Can I recommend the name "index" instead of "number"? |
I think it is a good proposal to avoid confusion. But this will need to be addressed in a separate pull request since we will need to update it also for all the other parsers, and some functions like The goal of this pull request is to have the same behaviour as the musicxml parser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggested change works and corresponds to how we parse measures in musicxml.
The Measure
object has the number
and name
attributes. Currently, the number
attribute represents a running count of measures (tags), irrespective of their regularity or volta endings - thus it starts at 1 and continuously increments. However, we could also interpret number
more akin to an index (as suggested here) - and rename it to index
accordingly. Let me know what you prefer.
I found a bug with volta measures and corrected it. I would need new approval. Thank you! |
Fixed a problem with Measure elements in MEI loading.
Now measure has 2 attributes: