Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_note_features breaks for force_fixed_size=True and 'unknown_direction' in score #271

Closed
sildater opened this issue Jun 15, 2023 · 0 comments · Fixed by #273
Closed
Assignees
Labels
bug Something isn't working

Comments

@sildater
Copy link
Member

possible bug fix: correct naming in line 722 return "unknown_direction" to return "unknown_articulation"

reproduce:

import partitura as pt
part = pt.load_musicxml("beethoven_op002_no2_mv4.xml")[0] # zeilinger
nf = pt.musicanalysis.compute_note_array(part, feature_functions=["articulation_direction_feature"], force_fixed_size=True)

gives

--> 747         j = names.index(name)
    748     else:
    749         names[j] = name

ValueError: 'unknown_direction' is not in list
@sildater sildater added the bug Something isn't working label Jun 15, 2023
@sildater sildater self-assigned this Jun 15, 2023
sildater added a commit that referenced this issue Jun 15, 2023
@manoskary manoskary linked a pull request Jun 15, 2023 that will close this issue
manoskary added a commit that referenced this issue Jun 15, 2023
@sildater sildater mentioned this issue Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant