-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving unit documentation #717
Conversation
MoM: Please review |
Thanks for creating a PR to resolve Issues #690 in the way we concluded earlier. Just for clarification, do we want to indicate that the use of an alternative unit can require additions to the units file? For instance, miles per hour (mph) is a unit that some regions use for Vehicle.speed but this is undefined in units.yaml. Also, please find below some very minor nits and suggested resolutions:
|
Thanks for the comments. I think it could make sense to add a section on what to do if you need or want a new unit like |
fbef3cf
to
244764b
Compare
Signed-off-by: Erik Jaegervall <[email protected]>
244764b
to
a94d3ba
Compare
Refactored a bit to address the comments of @nickrbb |
Thanks @erikbosch for the updates, all looks good. I might create a new PR to add mph as a unit to the units file then, but as previously discussed and concluded, we will leave it to the API to determine its use in added or modified signals. |
MoM: Merge |
Based on discussion in #690, clarify that use of of alternative units is not a topic for VSS but rather APIs
Fixes #690