Adding signals for width and turn diameter #657
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by some signals in Android VHAL with no corresponding signals in VSS; In
INFO_EXTERIOR_DIMENSIONS
there are fields for width with and without mirrors and also turn diameter.We could possibly make use of 3 widths
Here we have SAE definitions we could use. We already have a Width signal, but that signal does not specify how width shall be measured. It is suggested to mark that signal as deprecated (for VSS 4.1) and thus with our present deprecation process remove it for VSS 5.0
For turn diameter two measurement can be used, wall-to-wall and curb-to-curb. The SAE standard only give a definition for wall-to-wall:
"Diameter of the minimum cylindrical envelope in which the
vehicle can drive a circle with the front wheels at maximum
lock (between walls). If different between left and right turn,
the larger one is reported".
That is the diameter proposed in this PR