Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding signals for width and turn diameter #657

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

erikbosch
Copy link
Collaborator

@erikbosch erikbosch commented Sep 22, 2023

This is inspired by some signals in Android VHAL with no corresponding signals in VSS; In INFO_EXTERIOR_DIMENSIONS there are fields for width with and without mirrors and also turn diameter.

We could possibly make use of 3 widths

  • Excluding mirrors
  • With mirrors folded
  • With mirrors in normal position

Here we have SAE definitions we could use. We already have a Width signal, but that signal does not specify how width shall be measured. It is suggested to mark that signal as deprecated (for VSS 4.1) and thus with our present deprecation process remove it for VSS 5.0

For turn diameter two measurement can be used, wall-to-wall and curb-to-curb. The SAE standard only give a definition for wall-to-wall:

"Diameter of the minimum cylindrical envelope in which the
vehicle can drive a circle with the front wheels at maximum
lock (between walls). If different between left and right turn,
the larger one is reported".

That is the diameter proposed in this PR

@erikbosch erikbosch added the Status:New An issue/PR that not yet have been discussed/announced at a VSS meeting label Sep 22, 2023
@erikbosch
Copy link
Collaborator Author

Meeting notes:

  • Please review
  • Nick: Better to duplicate signal instead of changing meaning, like WidthExcludingMirrors, Keep Width, mark obsolete

@SebastianSchildt
Copy link
Collaborator

I don't think in VSS we want both turning radii. More practical seems to have "wall-to-wall", see also Wikipedia, just calling that TuringDiameter, and write in description the specific definition used

https://en.wikipedia.org/wiki/Turning_radius

@erikbosch erikbosch added Status:Review Please review/discuss contents and removed Status:New An issue/PR that not yet have been discussed/announced at a VSS meeting labels Oct 2, 2023
@erikbosch
Copy link
Collaborator Author

Meeting notes:

  • Please review, potential merge at next meeting

@erikbosch
Copy link
Collaborator Author

Meeting note: merge

@erikbosch erikbosch added Status:Approved Approved to merge and removed Status:Review Please review/discuss contents labels Oct 19, 2023
@erikbosch erikbosch merged commit 2b38850 into COVESA:master Oct 19, 2023
3 checks passed
@erikbosch erikbosch deleted the erik_width branch October 19, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Approved Approved to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants