Cice grid generation

[anton-seaice]

Companion pull request to ACCESS-NRI/om3-scripts#8

• fixes angle T
• adds cf compliant variable names
• add versioning to output

EDIT: This PR also adds tests. See COSIMA/om3-utils#5 for full scope of changes and review

[anton-seaice]

I tried to run the tests ... it looks like they rely on some test data which doesn't exist anymore.

I get a 404 error trying to download from this link:

http://s3-ap-southeast-2.amazonaws.com/dp-drop/esmgrids/test/test_data.tar.gz

[anton-seaice]

@aekiss & @ezhilsabareesh8 Can you review please?

[anton-seaice]

@aekiss & @ezhilsabareesh8 Can you review please?

Bump :)

[ezhilsabareesh8]

Thanks Anton, it looks good to me and clear

[ezhilsabareesh8]

I think it would be add a comment why we are changing the index to 1::2, 1::2

[anton-seaice]

I don't know how to write a concise comment to say it ... The rest of the file is uncommented so i just followed that style !

[micaeljtoliveira]

@anton-seaice I suggest you drop the last three commits and rebase onto the latest main.

[dougiesquire]

@anton-seaice, I'm happy to do a review once you've brought in the relevant parts of COSIMA/om3-utils#5 (i.e. the additional provenance metadata and the tests)

[anton-seaice]

@dougiesquire I think this is mostly done. Its a bit messy, which I will try and tidy up.

[dougiesquire]

@anton-seaice I'm not working today, but let me know when you're done making changes and I'll do a review first thing tomorrow

[codecov]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

[micaeljtoliveira]

Yeah, hopefully it would never look like that in production files, since the last part indicates uncommitted changes (which we can never keep track of). I would hope that all production files would be created with tagged releases ( so something like 0.2.0), but even unreleased commits will be kept track of (e.g. 0.2.0.dev+g).

One could add a check to stop the code if the file is being generated with uncommitted changes and issue a warning if it's not a tagged release.

[dougiesquire]

One could add a check to stop the code if the file is being generated with uncommitted changes and issue a warning if it's not a tagged release.

Sure, I'll do that now

[dougiesquire]

@anton-seaice, one more PR from me. Then IMO we're ready for a final review and merge

[dougiesquire]

LGTM! Thanks for this @anton-seaice - a big and important chunk of work

[aekiss]

Thanks @anton-seaice and everyone - great work!