Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add some more edge cases to session management for users login and logout sessions #71

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Jun 19, 2024

Description

This pr aims to address an issue whereby a suers session was not being cleared when they logged out and aims to introduce some additional security measurements to management of users session during route acessing through middleware

Fixes # (issue)
N/A

Type of change

Bug fix

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Different domains were mocked to ensure that cookies are indeed cleared outside of the scope of a localhost domain
  • Some of the logic for accessing protected routes under middleware were redesigned in a minor way

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@waveyboym waveyboym added type: bug Something isn't working type: fix Introduces a fix for a previous issue type: security This is a security related issue/pr For: api This is mainly for the api For: backend This is mainly for the backend code priority: critical This needs/needed to be addressed immediately effort: 5 This may require/required hours of work labels Jun 19, 2024
@waveyboym waveyboym added this to the Demo two milestone Jun 19, 2024
@waveyboym waveyboym self-assigned this Jun 19, 2024
@waveyboym waveyboym marked this pull request as ready for review June 19, 2024 20:31
@waveyboym waveyboym merged commit cf246e5 into develop Jun 19, 2024
4 checks passed
@waveyboym waveyboym deleted the fix/backend/logout-session-management branch June 19, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 5 This may require/required hours of work For: api This is mainly for the api For: backend This is mainly for the backend code priority: critical This needs/needed to be addressed immediately type: bug Something isn't working type: fix Introduces a fix for a previous issue type: security This is a security related issue/pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant