Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PDF download button in OccupancyModal component #415

Merged
merged 14 commits into from
Oct 1, 2024

Conversation

Tinashe-Austin
Copy link
Contributor

@Tinashe-Austin Tinashe-Austin commented Oct 1, 2024

Description

minor bug fix
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Tinashe-Austin Tinashe-Austin added the effort: 2 This can be/was resolved in minutes but requires/required shallow engagement label Oct 1, 2024
@Tinashe-Austin Tinashe-Austin self-assigned this Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.94%. Comparing base (93e3d8b) to head (24f89a0).
Report is 15 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (93e3d8b) and HEAD (24f89a0). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (93e3d8b) HEAD (24f89a0)
3 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #415       +/-   ##
============================================
- Coverage    79.34%   59.94%   -19.40%     
============================================
  Files           96       74       -22     
  Lines         5988     1548     -4440     
  Branches       126        0      -126     
============================================
- Hits          4751      928     -3823     
+ Misses        1139      620      -519     
+ Partials        98        0       -98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tinashe-Austin Tinashe-Austin merged commit a839016 into develop Oct 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 2 This can be/was resolved in minutes but requires/required shallow engagement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant