Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added role change stuff #412

Merged
merged 14 commits into from
Sep 30, 2024
Merged

added role change stuff #412

merged 14 commits into from
Sep 30, 2024

Conversation

Tinashe-Austin
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.75%. Comparing base (12399f0) to head (6f7870a).
Report is 15 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (12399f0) and HEAD (6f7870a). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (12399f0) HEAD (6f7870a)
3 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #412       +/-   ##
============================================
- Coverage    80.64%   43.75%   -36.90%     
============================================
  Files           88       66       -22     
  Lines         5331     1136     -4195     
  Branches        84        0       -84     
============================================
- Hits          4299      497     -3802     
+ Misses         938      639      -299     
+ Partials        94        0       -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tinashe-Austin Tinashe-Austin self-assigned this Sep 30, 2024
@Tinashe-Austin Tinashe-Austin added type: chore Just a cleanup or minor update type: fix Introduces a fix for a previous issue priority: low This does/did not need to be addressed any time soon effort: 2 This can be/was resolved in minutes but requires/required shallow engagement platform: mobile This is related to mobile platforms platform: web/desktop This is related to web/desktop platforms For: integration This is for work involving integration with the backend/model API labels Sep 30, 2024
@Tinashe-Austin Tinashe-Austin merged commit efe2903 into develop Sep 30, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 2 This can be/was resolved in minutes but requires/required shallow engagement For: integration This is for work involving integration with the backend/model API platform: mobile This is related to mobile platforms platform: web/desktop This is related to web/desktop platforms priority: low This does/did not need to be addressed any time soon type: chore Just a cleanup or minor update type: fix Introduces a fix for a previous issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant