Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UX for some of the login related pages #337

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Aug 23, 2024

Description

Revamped a little bit of the login related pages and added pages for reset-password, and forgot-password

Fixes # (issue)
#327

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@waveyboym waveyboym added type: feature A new feature type: fix Introduces a fix for a previous issue For: frontend This is mainly related to frontend UI code priority: high This needs/needed to be addressed as soon as possible effort: 5 This may require/required hours of work platform: web/desktop This is related to web/desktop platforms labels Aug 23, 2024
@waveyboym waveyboym added this to the Week 1 Sprint 4 milestone Aug 23, 2024
@waveyboym waveyboym self-assigned this Aug 23, 2024
@waveyboym waveyboym linked an issue Aug 23, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (be356ee) to head (9a04ddb).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##           develop      #337       +/-   ##
=============================================
+ Coverage    79.53%   100.00%   +20.46%     
=============================================
  Files           53        32       -21     
  Lines         3260       751     -2509     
  Branches        81         0       -81     
=============================================
- Hits          2593       751     -1842     
+ Misses         578         0      -578     
+ Partials        89         0       -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waveyboym waveyboym merged commit 57b6f30 into develop Aug 23, 2024
7 checks passed
@waveyboym waveyboym deleted the refactor/frontend/login-ux branch August 23, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 5 This may require/required hours of work For: frontend This is mainly related to frontend UI code platform: web/desktop This is related to web/desktop platforms priority: high This needs/needed to be addressed as soon as possible type: feature A new feature type: fix Introduces a fix for a previous issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Revamp UX for login page web
1 participant