Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/backend/mail switch to bcc headers #336

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Aug 23, 2024

Description

This pr introduces some complementary code to complete the moving of mail services to no longer use a test mail but a real email, namely [email protected]. It also moves from using concurrent mail sending to using bcc headers instead

Fixes # (issue)
#335
#310

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested with postman to observe expected behavior and worked as expected. The only ensuing problem was that mail went to spam and not to the direct mailbox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@waveyboym waveyboym added type: feature A new feature type: fix Introduces a fix for a previous issue type: security This is a security related issue/pr For: api This is mainly for the api For: backend This is mainly for the backend code priority: medium This does/did not need to be addressed soon but should have plans in place to be addressed effort: 5 This may require/required hours of work For: deployment This will affect our deployed system labels Aug 23, 2024
@waveyboym waveyboym added this to the Week 1 Sprint 4 milestone Aug 23, 2024
@waveyboym waveyboym self-assigned this Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.39%. Comparing base (be356ee) to head (086a187).
Report is 4 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (be356ee) and HEAD (086a187). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (be356ee) HEAD (086a187)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #336      +/-   ##
===========================================
- Coverage    79.53%   74.39%   -5.15%     
===========================================
  Files           53       10      -43     
  Lines         3260     1984    -1276     
  Branches        81        0      -81     
===========================================
- Hits          2593     1476    -1117     
+ Misses         578      460     -118     
+ Partials        89       48      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waveyboym waveyboym merged commit e505fa7 into develop Aug 23, 2024
6 of 7 checks passed
@waveyboym waveyboym deleted the refactor/backend/mail-switch-to-bcc-headers branch August 23, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 5 This may require/required hours of work For: api This is mainly for the api For: backend This is mainly for the backend code For: deployment This will affect our deployed system priority: medium This does/did not need to be addressed soon but should have plans in place to be addressed type: feature A new feature type: fix Introduces a fix for a previous issue type: security This is a security related issue/pr
Projects
None yet
1 participant