Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/backend/switching from bigcache to go redis #334

Merged
merged 19 commits into from
Aug 22, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Aug 22, 2024

Description

This pr proposes changing from bigcache to go-redis

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Converted the vast majority of database functions to use go-redis and mock go-redis
  • Wrote new unit tests for some functions in utils and cache

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@waveyboym waveyboym added type: feature A new feature type: testing This affects one or more tests For: api This is mainly for the api For: backend This is mainly for the backend code priority: medium This does/did not need to be addressed soon but should have plans in place to be addressed effort: 8 This may require/required a week of work at minimum labels Aug 22, 2024
@waveyboym waveyboym added this to the Week 1 Sprint 4 milestone Aug 22, 2024
@waveyboym waveyboym self-assigned this Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 68.18182% with 35 lines in your changes missing coverage. Please review.

Project coverage is 73.39%. Comparing base (b831e09) to head (02dd82d).
Report is 20 commits behind head on develop.

Files Patch % Lines
occupi-backend/pkg/database/database_helpers.go 50.00% 31 Missing ⚠️
occupi-backend/pkg/cache/cache.go 91.48% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b831e09) and HEAD (02dd82d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b831e09) HEAD (02dd82d)
3 2
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #334      +/-   ##
===========================================
- Coverage    79.27%   73.39%   -5.89%     
===========================================
  Files           53       21      -32     
  Lines         3209     2507     -702     
  Branches        81       81              
===========================================
- Hits          2544     1840     -704     
- Misses         577      578       +1     
- Partials        88       89       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waveyboym waveyboym merged commit be356ee into develop Aug 22, 2024
7 of 9 checks passed
@waveyboym waveyboym deleted the feat/backend/switching-from-bigcache-to-go-redis branch August 22, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 8 This may require/required a week of work at minimum For: api This is mainly for the api For: backend This is mainly for the backend code priority: medium This does/did not need to be addressed soon but should have plans in place to be addressed type: feature A new feature type: testing This affects one or more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant