Open
Conversation
TYPE: bug fix
KEYWORDS: ghg_input, idealized, no radiation
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
Most idealized cases have radiation options turned off, which causes the following error message to inaccurately print to the rsl files when ideal.exe is run:
ERROR: ghg_input available only for these radiation schemes: CAM, RRTM,
RRTMG, RRTMG_fast
And the LW and SW schemes must be reasonably paired together:
OK = CAM LW with CAM SW
OK = RRTM, RRTMG LW or SW, RRTMG_fast LW or SW may be mixed
Solution:
In share/module_check_a_mundo.F, add code to ensure that when radiation is turned off, not only does the message not print, but the namelist value for ghg_input is set to 0, as well.
LIST OF MODIFIED FILES:
M share/module_check_a_mundo.F
TESTS CONDUCTED:
1. Code compiles okay and no longer prints the message for idealized cases (tested with em_quarter_ss).
2. The Jenkins tests are all passing.
RELEASE NOTE: This PR fixes an erroneous print for using ghg_input when no radiation option is selected, mostly from idealized cases.
TYPE: bug fix KEYWORDS: Urban, Noah-MP, LCZ SOURCE: Martilli, Alberto (CIEMAT) DESCRIPTION OF CHANGES: Problem: If one uses Noah-MP and LCZ data, all the LCZ_1, LCZ_2, etc. are zero because they are not defined correctly for Noah-MP. Solution: This PR fixes the issue by using LCZ_*_TABLE instead so that LCZ are correctly defined in Noah-MP. LIST OF MODIFIED FILES: M phys/module_surface_driver.F TESTS CONDUCTED: 1. A one-month simulation was conducted for February 2018 over Atlanta to verify the change. 2. The Jenkins tests are all passing. RELEASE NOTE: This PR fixes an error associated with using LCZ categories in NoahMP. Prior to this fix, the LCZs were not correctly referenced, hence ignored in the NoahMP code.
This has all current bug fixes and no new features (since WRF v4.5.1), so it should work fine.
To include the updated CBIOM values (see CORDEX-WRF-community/noahmp@a10d606f)
The default (1) leads to crashes with SLUCM urban option. See CORDEX-WRF-community/fps-urb-rcc#4
to point to the CWC repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the base branch to develop CWC WRF v4.6.1.1. Propose your bug fixes and developments for this release against this branch.
RELEASE NOTE:
Fixes applied from WRF v4.7.1: